[6.2][wasm] Rename wasm32-unknown-wasi to wasm32-unknown-wasip1
#83199
+9
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
added
the
🍒 release cherry pick
MaxDesiatov
added
WebAssembly
|
@swift-ci build toolchain |
|
@swift-ci test |
kateinoigakukun
added a commit
to swiftlang/swift-sdk-generator
that referenced
this pull request
Jul 21, 2025
… exist (#230) Cherry-pick #229 to release/6.2 to unblock swiftlang/swift#83199 --------- Co-authored-by: Max Desiatov <m_desiatov@apple.com>
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci test linux |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
bnbarham
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Renames the WebAssembly target triple from
wasm32-unknown-wasitowasm32-unknown-wasip1to align with the broader WebAssembly ecosystem's naming conventions. It's important to include this in 6.2, which is going to be the first stable release of Swift SDK for Wasm, so that we won't introduce a breaking triple change in the stable version series later.The WebAssembly ecosystem has been migrating from the generic wasi target name to more explicit version-specific names like
wasip1andwasip2. This change has been adopted across multiple toolchains and language ecosystems:wasm32-wasitowasm32-wasip1(Renamewasm32-wasitarget towasm32-wasi-preview1rust-lang/compiler-team#607)wasm32-wasitowasm32-wasip1(Start renaming preview1 to p1 and preview2 to p2 WebAssembly/wasi-sdk#386)wasip1naming convention (all: add GOOS=wasip1 GOARCH=wasm port golang/go#58141)The "p1" suffix explicitly indicates WASI Preview 1, which helps distinguish it from the newer WASI Preview 2 (wasip2) and provides clarity about which version of the WASI specification is being targeted.
Also we already use
wasm32-unknown-wasip1for Embedded WASI target, and having different names for Embedded and non-Embedded is confusing users.Scope: Narrow, only affects Wasm Swift SDK.
Original PRs: [wasm] Rename
wasm32-unknown-wasitowasm32-unknown-wasip1#83167Risk: Low, just a change to Wasm Swift SDK
Testing: CI.
Reviewers: @MaxDesiatov