[6.2][Concurrency/Distributed] ensure distributed thunks are @concurrent #83997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stributed thunks the new NonisolatedNonsendingByDefault upcoming feature breaks remote calls in distributed actors, because the expected isolation doesn't match and the runtime swift_distributed_execute_target_resume will crash. This is a short term fix to unblock adopters, however preferably we should mark the thunks as nonisolated(nonsending), though that seems to be more involved. resolves rdar://159247975
|
@swift-ci please smoke test |
|
@swift-ci please test |
ktoso
changed the title
ktoso
changed the title
Otherwise the "nonisolated nonsending by default" mode blows up as distributed thunk signatures dont match expectations. This undoes the fix from swiftlang#83940 and applies the fix on the synthesis side of the distributed thunks, such that they are @Concurrent always -- which keeps their old semantics basically, regardless of what "default" mode we have.
ktoso
changed the title
|
@swift-ci please test |
hborla
approved these changes
Sep 4, 2025
|
@swift-ci please test |
ktoso
deleted the
pick-nonisolatednonsending-by-default-and-distributed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: the new NonisolatedNonsendingByDefault upcoming feature breaks remote calls in distributed actors, because the expected isolation doesn't match and the runtime swift_distributed_execute_target_resume will crash.
Scope/Impact: Only impacts distributed thunks generated for distributed methods, such that the NonisolatedNonsendingByDefault does not affect them, as it would cause crashes in mismatch of runtime and generated funcs expectations.
Risk: Low, unbreaks mismatch in parameter alignment.
Testing: Added test which reproduces the issue
Reviewed by: @xedin
Original PR: #83940 #84072
Radar: rdar://159247975