[Concurrency/Distributed] ensure distributed thunks are @concurrent #84072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the "nonisolated nonsending by default" mode blows up as distributed thunk signatures dont match expectations. This undoes the fix from #83940 and applies the fix on the synthesis side of the distributed thunks, such that they are @Concurrent always -- which keeps their old semantics basically, regardless of what "default" mode we have.
|
@swift-ci please smoke test |
This was referenced Sep 3, 2025
xedin
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the "nonisolated nonsending by default" mode blows up as
distributed thunk signatures dont match expectations.
This is a follow up from #83940
And solves the issue by instead adjusting the synthesis side of the distributed thunks,
such that they are
@concurrentalways -- which keeps their old semanticsbasically, regardless of what "default" mode we have.
Resolves rdar://159247975