-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with the unsafe flags error #6
Comments
Yes, you can't use a tag to specify a fixed revision due to unsafe flags. But in the long run, we need to support these flags safely in SwiftPM. |
These SwiftWasm snapshots should be more stable in general and also have a workaround for swiftwasm/JavaScriptKit#6 included. They still use the old metadata layout, so Runtime and OpenCombine dependencies had to be updated in `Package.swift` for `@ObservableObject` to work with these snapshots.
* Use the latest 5.3 snapshot in `.swift-version` These SwiftWasm snapshots should be more stable in general and also have a workaround for swiftwasm/JavaScriptKit#6 included. They still use the old metadata layout, so Runtime and OpenCombine dependencies had to be updated in `Package.swift` for `@ObservableObject` to work with these snapshots. * Fix linter warning
I think this becomes a higher priority as it prevents any projects that depend on JavaScriptKit from being built for any platform other than WASI. For example, it's currently blocking TokamakUI/Tokamak#276. The big problem is that it may require changes to the package manifest API, such as new safe linker settings. Any new settings won't be available on non-WASI platforms until the next version of Swift is released. If we add new linker settings, they definitely need to land upstream before the next version is branched off, but I think we also need to find some workaround in the meantime. |
Here's a possible solution that I proposed in the
Yuta noted that:
My counterargument is that upstream Swift for Linux has monthly patch releases anyway. So we'd expect 5.3.1 in October/November, 5.3.2 in December etc. I think we'd probably want our SwiftWasm patch releases for 5.3 to follow that schedule too. Would JavaScriptKit change linker flags more frequently than once a month? If not, that would be an acceptable workaround until the next version of Swift is released. I hope we'll see Swift 5.4 or whatever the next version will be (maybe even Swift 6.0?) early next year. At least that was the upstream schedule recently: at least two minor releases a year, and patch releases every month for Linux (and now for Windows I guess) So we only need to live with this workaround until early next year if all goes well 🙂 |
…fined at link time. Differential Revision: https://reviews.llvm.org/D74110
I have a very trivial app here that depends on JavaScriptKit, but it fails to build with this error:
The text was updated successfully, but these errors were encountered: