-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all unsafe linker flags from Package.swift #91
Conversation
36b2e89
to
dbfb722
Compare
2094101
to
61a6b65
Compare
Time Change: -3,591.5ms (38%) 🎉 Total Time: 9,306.5ms
ℹ️ View Unchanged
|
.github/workflows/perf.yml
Outdated
@@ -16,6 +16,7 @@ jobs: | |||
export SWIFTENV_ROOT="$HOME/.swiftenv" | |||
export PATH="$SWIFTENV_ROOT/bin:$PATH" | |||
eval "$(swiftenv init -)" | |||
./scripts/install-toolchain.sh | |||
swiftenv install $TOOLCHAIN_DOWNLOAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove swiftenv install line after merging this PR because older version toolchain is necessary to compare with base branch
61a6b65
to
bb3a3e0
Compare
The reason for the performance improvement is that we started to build toolchain without assertion. |
Is that expected? I’m pretty sure the benchmarks only measure runtime performance, not built time. Or am I missing something about what “building without assertions” means? |
@j-f1 It's an expected result. Because stdlib binary is built without any |
Do you know if upstream distributions disable assertions by the way? I thought that we disabled assertions temporarily until swiftwasm/swift#1823 is fixed. |
@MaxDesiatov IMO, we should disable assertion for distribution toolchains even swiftwasm/swift#1823 will be fixed. I'm not sure which build-preset is used for upstream toolchain distribution, but they use no-assertion for release version toolchain in general. |
@MaxDesiatov @j-f1 Can we merge this PR or do I need more detail description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, I look forward to building Tokamak on Linux or macOS 🙂
Need toolchain including swiftwasm/llvm-project@20c933e
Resolve #6