Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --destination option to SourceKit-LSP to use for indexing #1935

Closed
MaxDesiatov opened this issue Oct 6, 2020 · 2 comments
Closed

Add --destination option to SourceKit-LSP to use for indexing #1935

MaxDesiatov opened this issue Oct 6, 2020 · 2 comments
Labels
wontfix This will not be worked on

Comments

@MaxDesiatov
Copy link

One more thing for the release I want to try is to patch SourceKit-LSP so that it can take a --destination argument and pass it to swift build. This should make it possible to get autocomplete in VSCode with Tokamak and projects that depend on it.

Originally posted by @MaxDesiatov in #1759 (comment)

@MaxDesiatov MaxDesiatov changed the title Add --destination flag to SourceKit-LSP to use for indexing Add --destination option to SourceKit-LSP to use for indexing Oct 6, 2020
@MaxDesiatov
Copy link
Author

I wasn't able to make it work right now the way I envisioned it initially. But now that JavaScriptKit no longer uses unsafe flags, I think this change is less critical. Package.swift for most if not all SwiftWasm project can be opened in Xcode and get auto-complete working, and it should work in VSCode as well w/o any changes. Please report issues with this approach if any are found.

@MaxDesiatov MaxDesiatov added the wontfix This will not be worked on label Nov 12, 2020
@MaxDesiatov
Copy link
Author

I don't think that the approach described originally is suitable anymore. We've got autocomplete working with most if not all of our libraries, now that they can be compiled on host architectures directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant