SwiftWasm 5.3.0 release checklist

[MaxDesiatov]

These are the things that would be great to see before SwiftWasm 5.3.0 is tagged:

• Re-enable stdlib test suite on CI for at least macOS in swiftwasm-release/5.3 branch, ideally on Linux too (it currently fails, but CI passes anyway). If this is blocked by Wasmer, we need to report this issue to them and link it here.
• Rename Glibc module to WASI in SwiftWasm 5.3 snapshots (tracked in Add WASI module to use instead of Glibc #196, fixed in Add WASI module to replace Glibc on WASI platform #1773 for swiftwasm-release/5.3 and in WASILibc module for main stream #1832 for swiftwasm)
• Fix linking issues in test targets (tracked in Building a test bundle fails with 5.3 snapshots #1824).
• Fix linker warnings in 5.3 toolchains (tracked in Linker warnings when building with the new 5.3 toolchain #1823).
• Add a guide for carton usage to the SwiftWasm book.
• Allow building JavaScriptKit without unsafe flags in its Package.swift (tracked in Build fails with the unsafe flags error JavaScriptKit#6)
• Ship working IndexStore in SwiftWasm 5.3 snapshots to allow swift test --enable-test-discovery (done in Install sourcekit-lsp #1845 and Ship IndexStore and SourceKit-LSP in 5.3 snapshots #1851)
• Ship SourceKit-LSP in SwiftWasm 5.3 snapshots (done in Install sourcekit-lsp #1845 and Ship IndexStore and SourceKit-LSP in 5.3 snapshots #1851)
• Fix missing Info.plist warning (tracked in Xcode warnings after installing .pkg toolchains #2072).
• Patch SourceKit-LSP to allow --destination option to be passed to it (tracked in Add --destination option to SourceKit-LSP to use for indexing #1935)
• Attempt integrating new LTO into swiftwasm-release/5.3 branch? I'm probably fine releasing 5.3.0 without it.

As usual, feedback is welcome. Lmk if you see anything's missing, but also bear in mind that the upstream 5.3.0 is going to be released very soon, almost certainly with iOS 14, so this list can't grow much more.

[kateinoigakukun]

Re-enable stdlib test suite on CI for at least macOS in swiftwasm-release/5.3 branch, ideally on Linux too (it currently fails, but CI passes anyway)

I think the stdlib test suites are running on macOS CI now.

Rename Glibc module to WASI in SwiftWasm 5.3 snapshots (tracked in #196, WIP in #1685)

I'll do this for 5.3 branch

Ship working IndexStore in SwiftWasm 5.3 snapshots to allow swift test --enable-test-discovery (WIP in #1496)

I'll take a look again for the failure reason

Attempt integrating new LTO into swiftwasm-release/5.3 branch? I'm probably fine releasing 5.3.0 without it.

I think it's too hard to integrate it with 5.3 branch at this time. I need to resolve conflict between 5.3 and master

[MaxDesiatov]

I've checked the latest 5.3 run on macOS and there are no test results in the logs, even though it seems like it attempts to build the stdlib unittest target. 🤔

[kateinoigakukun]

2020-09-25T16:41:44.1534080Z 5 warning(s) in tests
2020-09-25T16:41:44.1690960Z 
2020-09-25T16:41:44.1691620Z Testing Time: 663.31s
2020-09-25T16:41:44.1691900Z   Expected Passes    : 111
2020-09-25T16:41:44.1692190Z   Expected Failures  : 2
2020-09-25T16:41:44.1693490Z   Unsupported Tests  : 108

stdlib tests were done on CI but swift-test-results.tar.gz doesn't contain any result.

[MaxDesiatov]

One more thing for the release I want to try tomorrow is to patch SourceKit-LSP so that it can take a --destination argument and pass it to swift build. This should make it possible to get autocomplete in VSCode with Tokamak and projects that depend on it.

[kateinoigakukun]

Before releasing 5.3, I'll add additional configuration to publish toolchain as signed and installable via pkg installer.

[MaxDesiatov]

Awesome, thank you for taking care of this!

[MaxDesiatov]

@swiftwasm/swiftwasm-team looks like swift-wasm-5.3-SNAPSHOT-2020-10-20-a is our 5.3.0 release candidate, WDYT? Have you seen any issues with this toolchain or any other recent snapshots?

[kateinoigakukun]

I want to include #2054 also.

[MaxDesiatov]

Right, it was supposed to be included in 2020-10-21, but the nightly distribution script failed with The job running on runner GitHub Actions 3 has exceeded the maximum execution time of 360 minutes. As you have the signing assets, could you tag that snapshot one last time? We could look at the distribution/signing script later after 5.3.0 is released.

[kateinoigakukun]

Yes, the distribution script failed and I'm debugging it. OK, I'll publish today's toolchain from my local machine.

[MaxDesiatov]

Thanks, I appreciate it! Now that wasm-5.3-SNAPSHOT-2020-10-21-a is tagged, let's use that for a week and tag it as 5.3.0 after that if there are no issues or objections by then.