Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.5 release: fix cooperative global executor #3606

Merged
merged 9 commits into from
Sep 28, 2021
Merged

5.5 release: fix cooperative global executor #3606

merged 9 commits into from
Sep 28, 2021

Conversation

MaxDesiatov
Copy link

@kateinoigakukun @MaxDesiatov
[Concurrency] repair cooperative global executor
8b27d5e 
This patch guards some includes of libdispatch headers so that platforms
that doesn't support libdispatch can build cooperative executor runtime.
And fixed missing implementations for cooperative mode.

# Conflicts:
#	stdlib/public/Concurrency/GlobalExecutor.cpp
@kateinoigakukun @MaxDesiatov
[Concurrency] repair cooperative main executor
16b6fcf 
This patch repairs the build failure for cooperative executor.
And also fixed main executor to avoid assertion failure due to
`witnessTable == nullptr`

# Conflicts:
#	stdlib/public/Concurrency/GlobalExecutor.cpp
@kateinoigakukun @MaxDesiatov
[test] fix runtime unittests for single threaded runtime
6c981c7 
Some headers switch their inline implementations based on
SWIFT_STDLIB_SINGLE_THREAD_RUNTIME definition.
This fixes linking failure while building runtime unittests

# Conflicts:
#	stdlib/public/Concurrency/Mutex.cpp
@kateinoigakukun @MaxDesiatov
[test] disable async_task_locals_copy_to_sync.swift on single thread
6b7c366
@kateinoigakukun @MaxDesiatov
[test] mark multi-thread based tests as UNSUPPORTED in single-thread
0a0c97a 
Some of test cases assumes that the runtime is built for multi-threaded
platform.

# Conflicts:
#	test/Concurrency/Runtime/cancellation_handler.swift
#	test/Concurrency/Runtime/data_race_detection.swift
@kateinoigakukun @MaxDesiatov
[test] disable a part of unittests/runtime/Concurrent.cpp for single-…
8d08301 
…thread runtime
@kateinoigakukun @MaxDesiatov
[test] disable unittests/runtime/Mutex.cpp for single-thread runtime
d663923 
# Conflicts:
#	unittests/runtime/CMakeLists.txt
@MaxDesiatov MaxDesiatov mentioned this pull request Sep 28, 2021
Closed
8 tasks
@MaxDesiatov MaxDesiatov added the release Issues with the release version label Sep 28, 2021
@MaxDesiatov MaxDesiatov requested a review from a team September 28, 2021 14:46
@MaxDesiatov MaxDesiatov requested a review from a team September 28, 2021 15:22
@MaxDesiatov MaxDesiatov merged commit 11347a0 into swiftwasm-release/5.5 Sep 28, 2021
@MaxDesiatov MaxDesiatov deleted the maxd/5.5-cooperative-executor branch October 20, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
release Issues with the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun