Skip to content

Commit

Permalink
chore(styles): cleans up placeholder folder (#2171)
Browse files Browse the repository at this point in the history
The unnused placeholders in _text.scss will be deprecated and will be
deleted in the next version as mentioned in the changeset.

The removal will be done in this issue #2202 


Please be advised after merging this PR an error will occur when trying
to build packages depending on the styles package.
delete your dist folder in the styles package but especially the
/placeholder/badge.scss file to resovle this.

---------

Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
  • Loading branch information
b1aserlu and gfellerph committed Nov 7, 2023
1 parent acc7983 commit 4a599cc
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/neat-maps-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-styles': patch
---

The following placeholders from the `\_text.scss` file are depreacted an will be removed in a future version: `%list-adjustment`, `%module-container`, `%default-module-spacer`, `%text-container`.
1 change: 1 addition & 0 deletions packages/components/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = {
],
overrides: [],
parser: '@typescript-eslint/parser',
ignorePatterns: ['.eslintrc.js'],
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
Expand Down
1 change: 0 additions & 1 deletion packages/styles/src/components/dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@use './../lic/bootstrap-license';
@use './../themes/bootstrap/dropdown' as bd;

@use './../placeholders/close';
@use './../variables/color';
@use './../variables/commons';
@use './../variables/icons';
Expand Down
1 change: 0 additions & 1 deletion packages/styles/src/mixins/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
@use './../variables/components/button';
@use './../variables/type';
@use './../variables/color' as color-var;
@use './../placeholders/color' as color-ph;
@use './../functions/contrast' as contrast-fn;
@use 'utilities';

Expand Down
File renamed without changes.
4 changes: 4 additions & 0 deletions packages/styles/src/placeholders/_index.scss
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
@use './badge';
@use './button';
@use './close';
@use './color';
@use './dropdown';
@use './text';

0 comments on commit 4a599cc

Please sign in to comment.