Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: placeholders remove unused placeholders from _text.scss #2202

Open
4 tasks
Tracked by #1215
b1aserlu opened this issue Nov 1, 2023 · 0 comments
Open
4 tasks
Tracked by #1215

Styles: placeholders remove unused placeholders from _text.scss #2202

b1aserlu opened this issue Nov 1, 2023 · 0 comments
Labels
💔 BREAKING This is a breaking change and results in a new major version ❇️ good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Breaking changes

Comments

@b1aserlu
Copy link
Contributor

b1aserlu commented Nov 1, 2023 •
edited
Loading

This ticket was created while cleaning up the placeholder folder in the issue #888 PR #2171
remove the following placeholders from _text.scc after doubble checking they are still unused:

  • %list-adjustment
  • %module-container
  • %default-module-spacer
  • %text-container
@b1aserlu b1aserlu added 📦 styles Related to the @swisspost/design-system-styles package next labels Nov 1, 2023
This was referenced Nov 1, 2023
Merged
Closed
@gfellerph gfellerph added the 💔 BREAKING This is a breaking change and results in a new major version label Nov 3, 2023
@gfellerph gfellerph mentioned this issue Nov 3, 2023
Open
b1aserlu added a commit that referenced this issue Nov 7, 2023
@b1aserlu @gfellerph
chore(styles): cleans up placeholder folder (#2171)
4a599cc 
The unnused placeholders in _text.scss will be deprecated and will be
deleted in the next version as mentioned in the changeset.

The removal will be done in this issue #2202 


Please be advised after merging this PR an error will occur when trying
to build packages depending on the styles package.
delete your dist folder in the styles package but especially the
/placeholder/badge.scss file to resovle this.

---------

Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@gfellerph gfellerph added this to the Next milestone Feb 15, 2024
@gfellerph gfellerph modified the milestones: Next, Breaking changes Jul 15, 2024
@gfellerph gfellerph removed the next label Jul 15, 2024
@gfellerph gfellerph added the ❇️ good first issue Good for newcomers label Aug 8, 2024
@schaertim schaertim assigned schaertim and unassigned schaertim Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💔 BREAKING This is a breaking change and results in a new major version ❇️ good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 💻 Ready for development
Milestone
Breaking changes
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/2202-styles-placeholders-remove-unused-placeholders-from-_textscss swisspost/design-system
4 participants
@gfellerph @oliverschuerch @schaertim @b1aserlu