Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The $fn callback of the map function adds the key parameter passed in… #160

Merged
merged 2 commits into from
Dec 9, 2023
Merged

The $fn callback of the map function adds the key parameter passed in… #160

merged 2 commits into from
Dec 9, 2023

Conversation

maxiaozhi
Copy link
Contributor

…to the $list array

@deminy deminy self-assigned this Dec 8, 2023
@deminy deminy self-requested a review December 9, 2023 18:43
deminy
deminy approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@deminy deminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I will get it merged later on and add some comments on the callback function.

Thanks for the PR.

@deminy deminy merged commit 4e3efcc into swoole:master Dec 9, 2023
@deminy deminy mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deminy deminy deminy approved these changes

Assignees

@deminy deminy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxiaozhi @deminy