Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring Swoole Library to latest #5224

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Conversation

deminy
Copy link
Member

@deminy deminy commented Dec 23, 2023

This is to merge latest code from Swoole Library.

Removed:

  • Dropped support for PHP 7 (from PHP 7.2 to 7.4).

Fixed:

Changed:

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (375908d) 72.98% compared to head (e6605a5) 72.95%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
- Coverage   72.98%   72.95%   -0.04%     
==========================================
  Files          69       69              
  Lines       14856    14858       +2     
==========================================
- Hits        10843    10839       -4     
- Misses       4013     4019       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matyhtf
Copy link
Member

matyhtf commented Dec 26, 2023

@deminy The unit test in CI failed. There is a fatal error in PHP and needs to be solved.

deminy added a commit to swoole/library that referenced this pull request Dec 27, 2023
using commit swoole/library@4a621c9a from the master branch
@deminy
Copy link
Member Author

deminy commented Dec 27, 2023

Fixed in Swoole Library ( swoole/library@6a4ca52 ) and updated the PR. Thanks

* Use commit swoole/library@2ff30e0 from the master branch.
* With PR swoole/library#166 included.
@matyhtf matyhtf merged commit e1ee8c3 into swoole:master Jan 2, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants