Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder doctests #370

Closed
wants to merge 4 commits into from
Closed

Conversation

alsuren
Copy link
Contributor

@alsuren alsuren commented Feb 23, 2022

There are a few tests that I have left as "compile_fail" because I don't fully understand how contexts and signals are expected to work in 0.8. Search for FIXME in the diff, to find them. Any guidance that can be provided on these points would be greatly appreciated.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #370 (d4e0f65) into master (499c9bb) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   63.53%   63.54%           
=======================================
  Files          48       48           
  Lines        7569     7570    +1     
=======================================
+ Hits         4809     4810    +1     
  Misses       2760     2760           
Impacted Files Coverage Δ
packages/sycamore/src/builder/agnostic/mod.rs 5.96% <0.00%> (ø)
packages/sycamore-macro/src/view/parse.rs 93.33% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499c9bb...d4e0f65. Read the comment docs.

@lukechu10 lukechu10 mentioned this pull request Mar 5, 2022
@lukechu10
Copy link
Member

Hello there. Sorry for taking so long to get to this.
With the new v2 reactive primitives, the old builder API didn't really play well with it, mainly because I kind of just changed the function signatures to make it compile without any attention to ergonomics.
I actually completely overhauled the builder API in #373 which makes the old builder API obsolete, so unfortunately, I'll be closing this PR now. Sorry again for all the work you put into this.
Thanks for understanding.

@lukechu10 lukechu10 closed this Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants