Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder API v2 #373

Merged
merged 13 commits into from
Mar 6, 2022
Merged

Builder API v2 #373

merged 13 commits into from
Mar 6, 2022

Conversation

lukechu10
Copy link
Member

Supersedes #370

@lukechu10 lukechu10 added BREAKING CHANGE Breaking changes introduced in this PR A-ergonomics Area: API ergonomics A-builder Area: builder API labels Mar 5, 2022
@lukechu10 lukechu10 mentioned this pull request Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #373 (bb484e4) into master (24a1c15) will decrease coverage by 0.86%.
The diff coverage is 0.80%.

❗ Current head bb484e4 differs from pull request most recent head 91e3969. Consider uploading reports for the commit 91e3969 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   63.53%   62.66%   -0.87%     
==========================================
  Files          48       47       -1     
  Lines        7569     7658      +89     
==========================================
- Hits         4809     4799      -10     
- Misses       2760     2859      +99     
Impacted Files Coverage Δ
docs/src/main.rs 0.44% <0.00%> (+<0.01%) ⬆️
packages/sycamore/src/builder.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/mod.rs 100.00% <ø> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore-macro/src/view/codegen.rs 95.94% <100.00%> (ø)
packages/sycamore/src/view.rs 75.53% <100.00%> (+0.17%) ⬆️
packages/sycamore-router/src/router.rs 25.00% <0.00%> (-0.27%) ⬇️
packages/sycamore-reactive/src/effect.rs 99.33% <0.00%> (+0.01%) ⬆️
packages/sycamore/src/utils/hydrate/mod.rs 80.00% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a1c15...91e3969. Read the comment docs.

@lukechu10 lukechu10 merged commit 8b2beb5 into master Mar 6, 2022
@lukechu10 lukechu10 deleted the new-builder branch March 6, 2022 03:27
@lukechu10 lukechu10 mentioned this pull request Apr 3, 2024
8 tasks
@lukechu10 lukechu10 mentioned this pull request Sep 4, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Area: builder API A-ergonomics Area: API ergonomics BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant