Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rcirc logging where the channel name has '/' in it #5343

Closed
wants to merge 1 commit into from

Conversation

aroig
Copy link
Contributor

@aroig aroig commented Mar 3, 2016

This happens when connecting to gitter via irc.gitter.im, for instance.
It turns out that channels are named like #syl20bnr/spacemacs. For the
logging to work, we need to create the directory #syl20bnr first.

@CestDiego
Copy link
Contributor

there are two approaches for this, for whoever plans to solve this;

  • Either the directory is created which would be nice because all of repos from syl20bnr would be under the #syl20bnr directory.
  • We escape the / in the names

@TheBB
Copy link
Contributor

TheBB commented Mar 9, 2016

@CestDiego This is a PR so presumably @aroig plans to solve it (and maybe has, I haven't looked at it).

@aroig
Copy link
Contributor Author

aroig commented Mar 9, 2016

This PR already solves it by creating the directory #syl20bnr.

@CestDiego
Copy link
Contributor

I missed this. Sorry. Good job

On Wed, Mar 9, 2016, 2:33 AM Abdó Roig-Maranges notifications@github.com
wrote:

This PR already solves it by creating the directory #syl20bnr.


Reply to this email directly or view it on GitHub
#5343 (comment).

Diego Berrocal
http://cestdiego.github.io

This happens when connecting to gitter via irc.gitter.im, for instance.
It turns out that channels are named like #syl20bnr/spacemacs. For the
logging to work, we need to create the directory #syl20bnr first.
@aroig aroig force-pushed the gh/rcirc-nested-logfile branch from 7521fd8 to 54755d6 Compare April 5, 2016 00:10
@CestDiego
Copy link
Contributor

CestDiego commented Jul 19, 2016

what's wrong with this PR? this looks like it's a fine solution @TheBB

@TheBB
Copy link
Contributor

TheBB commented Jul 19, 2016

I don't think I said there's anything wrong with it. :-P

@TheBB
Copy link
Contributor

TheBB commented Jun 18, 2017

Thanks! Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants