Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rcirc logging where the channel name has '/' in it #5343

Closed
wants to merge 1 commit into from
+5 −4
Closed

Fix rcirc logging where the channel name has '/' in it #5343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions layers/+chat/rcirc/packages.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@
(setq rcirc-log-flag t)
(defun rcirc-write-log (process sender response target text)
(when rcirc-log-directory
(when (not (file-directory-p rcirc-log-directory))
(make-directory rcirc-log-directory))
(with-temp-buffer
;; Sometimes TARGET is a buffer :-(
(when (bufferp target)
Expand All @@ -143,9 +141,12 @@
(insert "/" (downcase response) " "))
(insert text "\n")
;; Append the line to the appropriate logfile.
(let ((coding-system-for-write 'no-conversion))
(let ((coding-system-for-write 'no-conversion)
(logfile (concat rcirc-log-directory (downcase target))))
(when (not (file-directory-p (file-name-directory logfile)))
(make-directory (file-name-directory logfile)))
(write-region (point-min) (point-max)
(concat rcirc-log-directory (downcase target))
logfile
t 'quietly))))))
(add-hook 'rcirc-print-hooks 'rcirc-write-log)

Expand Down