-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move org essentials to spacemacs distro #5372
Conversation
👍 I don't understand why org isn't a part of Spacemacs. Pretty much everyone sometimes need to read README.org files for layers. And if we are going to fix #4399 with
|
to play devils advocate, orgmode is still a plaintext, readable fine even on paper or in any plain text editor. navigation somewhat suffers, and it's not as pretty, but it's not hell at all That said, I agree that at least some support for orgmode is needed closer to the core - it's one of most popular packages and reasons to migrate, as well as currently one of the best documentation formats for emacs users |
I read and edit org files on iPad as plain text files :/ |
org-imenu-depth 8) | ||
|
||
(with-eval-after-load 'org-indent | ||
(spacemacs|hide-lighter org-indent-mode)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we disable org-indent by default we can remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Forgot that we don't enable it anymore. Good point.
Nice work, the documentation will need to be split at some point but it can wait because this is something we have to rethink given we have multiple spacemacs layers now. |
6e5ba72
to
c36dab1
Compare
@syl20bnr thanks for review - fixed what you've asked. |
Ping, ping 😢 |
This branch has conflicts that must be resolved |
c36dab1
to
af0d502
Compare
Ok, updated this one as well. Would be nice to have it merged as soon as possible :) |
Now that we can sort PRs by 👍 reactions on the first post, that is a handy way for people to signal which PRs are most interesting to them. I've just added mine. |
And two goes from me. |
This should be mentioned somewhere so that everyone is aware. |
Also we can sort by the amount of confusion caused - neat. |
@JAremko just did it :) But do I really want to see it in Spacemacs? Hm. I wonder. |
Thank you ! 👍 |
Following #4277
I haven't touched readme file, because I think it's good to have all description in one place. Also, I didn't rename
org
layer to anything else. If you think that it's a good idea - just tell me (or it could be done via another PR / commit).I tested my changes in different situations and everything seems to be working. But since I don't know all use-cases of org layer, I would like to take some help from org users and those who don't use org at all.
In case you think that something is not in the right place (some configs should be moved from spacemacs-org to org or vice versa) just let's discuss :)