Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move org essentials to spacemacs distro #5372

Closed

Conversation

d12frosted
Copy link
Contributor

Following #4277


I haven't touched readme file, because I think it's good to have all description in one place. Also, I didn't rename org layer to anything else. If you think that it's a good idea - just tell me (or it could be done via another PR / commit).

I tested my changes in different situations and everything seems to be working. But since I don't know all use-cases of org layer, I would like to take some help from org users and those who don't use org at all.

In case you think that something is not in the right place (some configs should be moved from spacemacs-org to org or vice versa) just let's discuss :)

@JAremko
Copy link
Collaborator

JAremko commented Mar 5, 2016

👍 I don't understand why org isn't a part of Spacemacs. Pretty much everyone sometimes need to read README.org files for layers. And if we are going to fix #4399 with toc-org TOC will look rather ugly in the fundamental mode.

* Spacemacs documentation                                   :TOC_4_org:noexport:
 - [[#core-pillars][Core Pillars]]
   - [[#mnemonic][Mnemonic]]
   - [[#discoverable][Discoverable]]
   - [[#consistent][Consistent]]
   - [[#crowd-configured][Crowd-Configured]]
 - [[#highlighted-feature][Highlighted feature]]
 - [[#screenshots][Screenshots]]
 - [[#who-can-benefit-from-this][Who can benefit from this?]]

@a13ph
Copy link

a13ph commented Mar 5, 2016

to play devils advocate, orgmode is still a plaintext, readable fine even on paper or in any plain text editor. navigation somewhat suffers, and it's not as pretty, but it's not hell at all

That said, I agree that at least some support for orgmode is needed closer to the core - it's one of most popular packages and reasons to migrate, as well as currently one of the best documentation formats for emacs users

@d12frosted
Copy link
Contributor Author

to play devils advocate, orgmode is still a plaintext, readable fine even on paper or in any plain text editor. navigation somewhat suffers, and it's not as pretty, but it's not hell at all

I read and edit org files on iPad as plain text files :/

org-imenu-depth 8)

(with-eval-after-load 'org-indent
(spacemacs|hide-lighter org-indent-mode))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we disable org-indent by default we can remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Forgot that we don't enable it anymore. Good point.

@syl20bnr
Copy link
Owner

syl20bnr commented Mar 6, 2016

Nice work, the documentation will need to be split at some point but it can wait because this is something we have to rethink given we have multiple spacemacs layers now.

@d12frosted d12frosted force-pushed the org/spacemacs-included branch from 6e5ba72 to c36dab1 Compare March 7, 2016 09:09
@d12frosted
Copy link
Contributor Author

@syl20bnr thanks for review - fixed what you've asked.

@d12frosted
Copy link
Contributor Author

Ping, ping 😢

@JAremko
Copy link
Collaborator

JAremko commented Apr 5, 2016

This branch has conflicts that must be resolved :shipit:

@d12frosted d12frosted force-pushed the org/spacemacs-included branch from c36dab1 to af0d502 Compare April 5, 2016 10:37
@d12frosted
Copy link
Contributor Author

Ok, updated this one as well. Would be nice to have it merged as soon as possible :)

@JAremko
Copy link
Collaborator

JAremko commented Apr 5, 2016

@syl20bnr :shipit:

@TheBB
Copy link
Contributor

TheBB commented Apr 5, 2016

Now that we can sort PRs by 👍 reactions on the first post, that is a handy way for people to signal which PRs are most interesting to them. I've just added mine.

@JAremko
Copy link
Collaborator

JAremko commented Apr 5, 2016

And two goes from me.
@d12frosted Don't forger to selfthumb 😉

@nixmaniack
Copy link
Contributor

Now that we can sort PRs by 👍 reactions on the first post, that is a handy way for people to signal which PRs are most interesting to them.

This should be mentioned somewhere so that everyone is aware.

@JAremko
Copy link
Collaborator

JAremko commented Apr 5, 2016

Also we can sort by the amount of confusion caused - neat.

@d12frosted
Copy link
Contributor Author

Don't forger to selfthumb

@JAremko just did it :)

But do I really want to see it in Spacemacs? Hm. I wonder.

@syl20bnr
Copy link
Owner

syl20bnr commented Apr 8, 2016

Thank you ! 👍
I rearranged it a bit in commit ff7b839
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Apr 8, 2016
@syl20bnr syl20bnr removed the Merged label Apr 8, 2016
@d12frosted d12frosted deleted the org/spacemacs-included branch April 8, 2016 05:04
@JAremko JAremko mentioned this pull request Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants