Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet/desktop] feat: unit test spinner #1906

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

AnthonyLaw
Copy link
Member

What was the issue?

  • missing unit test in the SpinnerLoading component.

What's the fix?

  • Added unit test SpinnerLoading component.
  • Removed unused components SpinnerDots

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #1906 (e88b797) into feature/unit-tests-united-2 (7c24073) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feature/unit-tests-united-2    #1906      +/-   ##
===============================================================
+ Coverage                        34.63%   34.71%   +0.08%     
===============================================================
  Files                              586      585       -1     
  Lines                            14033    14031       -2     
  Branches                          2358     2358              
===============================================================
+ Hits                              4860     4871      +11     
+ Misses                            9107     9094      -13     
  Partials                            66       66              
Flag Coverage Δ
wallet-desktop 34.71% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/SpinnerLoading/SpinnerLoading.vue 93.33% <0.00%> (+73.33%) ⬆️

});
});
});
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test for what is rendered when disableCloseButton is true and false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to test it, it just render out <div /> as output.
I will try again to play around.

Base automatically changed from feature/unit-tests-united-2 to dev January 3, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants