Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet/desktop] feat: unit test spinner #1906

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions __tests__/components/SpinnerLoading.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* (C) Symbol Contributors 2022
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and limitations under the License.
*
*/
import SpinnerLoading from '@/components/SpinnerLoading/SpinnerLoading.vue';
import { getComponent } from '@MOCKS/Components';
import { Spin } from 'view-design';

describe('components/SpinnerLoading', () => {
const getSpinnerLoadingWrapper = (state = {}) => {
const mockAppStore = {
namespaced: true,
state: { loadingOverlayMessage: '', loadingDisableCloseButton: false },
getters: {
loadingOverlayMessage: (state) => state.loadingOverlayMessage,
loadingDisableCloseButton: (state) => state.loadingDisableCloseButton,
},
};

return getComponent(
SpinnerLoading,
{
app: mockAppStore,
},
{
...state,
},
{},
{},
undefined,
{
$Spin: Spin,
},
);
};

describe('closeScreen', () => {
test('store dispatches "app/SET_LOADING_OVERLAY" when provided close screen', () => {
// Arrange:
const wrapper = getSpinnerLoadingWrapper();

// Act:
// @ts-ignore
wrapper.vm.closeScreen();

// Assert:
expect(wrapper.vm.$store.dispatch).toBeCalledWith('app/SET_LOADING_OVERLAY', {
show: false,
message: '',
});
});
});
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test for what is rendered when disableCloseButton is true and false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to test it, it just render out <div /> as output.
I will try again to play around.

53 changes: 0 additions & 53 deletions src/components/SpinnerDots/SpinnerDots.less

This file was deleted.

17 changes: 0 additions & 17 deletions src/components/SpinnerDots/SpinnerDots.vue

This file was deleted.