Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation links #1441

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update documentation links #1441

merged 1 commit into from
Oct 23, 2023

Conversation

smnandre
Copy link
Member

  • update doclinks.js (and remove jquery usage)
  • update some links in BlogController
  • remove references to SensioFrameworkExtraBundle

@smnandre
Copy link
Member Author

CI fails because composer.lock was not updated, but i did not change the composer.json either 👼

@javiereguiluz
Copy link
Member

Thanks Simon! I like these changes.

@javiereguiluz javiereguiluz merged commit 578246c into symfony:main Oct 23, 2023
5 checks passed
@javiereguiluz javiereguiluz mentioned this pull request Oct 23, 2023
Merged
javiereguiluz added a commit to javiereguiluz/demo that referenced this pull request Nov 2, 2023
@javiereguiluz
minor symfony#1445 Tweak JS code and rebuild assets (javiereguiluz)
1f5547f 
This PR was merged into the main branch.

Discussion
----------

Tweak JS code and rebuild assets

A minor tweak in the JS code updated in symfony#1441.

Also, rebuild front-end assets because in this project we embed those. In real apps, the best practice is of course to not do this ... but this Demo project is special and needs to be fully working without running any command or installing anything else.

Commits
-------

6a6fe75 Tweak JS code and rebuild assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smnandre @javiereguiluz @yceruto