Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak JS code and rebuild assets #1445

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Oct 23, 2023

A minor tweak in the JS code updated in #1441.

Also, rebuild front-end assets because in this project we embed those. In real apps, the best practice is of course to not do this ... but this Demo project is special and needs to be fully working without running any command or installing anything else.

@smnandre
Copy link
Member

Oops, sorry 😶‍🌫️ @javiereguiluz

@WebMamba
Copy link

@javiereguiluz I tried it locally, and that does the fix! 👍

@javiereguiluz javiereguiluz merged commit 1f5547f into symfony:main Nov 2, 2023
5 checks passed
@javiereguiluz javiereguiluz deleted the continue_1441 branch November 2, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants