Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:registration-form] Removal of the createView() method, as it is no longer required to render the form #1455

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

mdoutreluingne
Copy link
Contributor

Fixes #1453

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One comment though...

@jrushlow jrushlow added Status: Waiting Feedback Needs feedback from the author Feature New Feature labels Feb 20, 2024
@jrushlow jrushlow changed the title [make:crud] Removal of the createView() method, as it is no longer required to render the form [make:registration-form] Removal of the createView() method, as it is no longer required to render the form Feb 20, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mdoutreluingne!

@jrushlow jrushlow removed the Status: Waiting Feedback Needs feedback from the author label Feb 20, 2024
@jrushlow jrushlow merged commit 7748414 into symfony:main Feb 20, 2024
6 checks passed
@jrushlow jrushlow mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Make:registration-form] Form errors are not handled
2 participants