Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:registration-form] Removal of the createView() method, as it is no longer required to render the form #1455

Merged
merged 6 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function register(Request $request, <?= $password_hasher_class_details->g
}

return $this->render('registration/register.html.twig', [
'registrationForm' => $form->createView(),
'registrationForm' => $form,
]);
}
<?php if ($will_verify_email): ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function request(Request $request, MailerInterface $mailer<?php if ($tran
}

return $this->render('reset_password/request.html.twig', [
'requestForm' => $form->createView(),
'requestForm' => $form,
]);
}

Expand Down Expand Up @@ -109,7 +109,7 @@ public function reset(Request $request, UserPasswordHasherInterface $passwordHas
}

return $this->render('reset_password/reset.html.twig', [
'resetForm' => $form->createView(),
'resetForm' => $form,
]);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testRegistrationValidationError()
$form['registration_form[plainPassword]'] = 'foo';
$client->submit($form);

$this->assertSame(200, $client->getResponse()->getStatusCode());
$this->assertSame(422, $client->getResponse()->getStatusCode());
mdoutreluingne marked this conversation as resolved.
Show resolved Hide resolved
$this->assertStringContainsString(
'There is already an account with this email',
$client->getResponse()->getContent()
Expand Down
Loading