Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] Document new form features #5934

Closed
4 tasks done
althaus opened this issue Nov 30, 2015 · 8 comments
Closed
4 tasks done

[2.8] Document new form features #5934

althaus opened this issue Nov 30, 2015 · 8 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) Hack Day hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@althaus
Copy link
Contributor

althaus commented Nov 30, 2015 •
edited by xabbuh
Loading

As a followup of #5179: The news list new features in the form component. Would be great to update the reference accordingly:

  • Added the prototype_data option to collection type
  • Added choice_translation_domain option for date-related types (this is missing in general for 2.7)
  • Allowed to return null for query_builder
  • Foundation 5 form theme

Ping @weaverryan

Cheers
Matthias
@weaverryan weaverryan added this to the 2.8 milestone Nov 30, 2015
@weaverryan weaverryan added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 30, 2015
@weaverryan
Copy link
Member

Thanks @althaus - I've marked this for 2.8 (as most of it is relevant to 2.8) and marked it as actionable.

@althaus
Copy link
Contributor Author

althaus commented Nov 30, 2015

OK. Will check if I can do some basics on this one again.

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

Fyi, I've check (4) as it's now mentioned in http://symfony.com/doc/current/cookbook/form/form_customization#what-are-form-themes The others seem to be still valid. Please note that the choice_translation_domain has now documentation, so it's simply a case of including the option in the date related articles.

@xabbuh xabbuh added the Form label Feb 7, 2016
@HeahDude HeahDude mentioned this issue Feb 24, 2016
Merged
wouterj added a commit that referenced this issue May 5, 2016
@wouterj
feature #6302 [Form] add choice_translation_domain option to date t…
c1f64b7 
…ypes (HeahDude)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] add `choice_translation_domain` option to date types

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8+
| Fixed tickets | partially #5934

Commits
-------

540cefe [Form] add `choice_translation_domain` option to date types
@HeahDude
Copy link
Contributor

HeahDude commented May 5, 2016 •
edited
Loading

Two first boxes can be checked now :)

@wouterj
Copy link
Member

wouterj commented May 21, 2016

The last open points is about http://symfony.com/doc/current/reference/forms/types/entity#query-builder It should be documented to accept returning null. See http://symfony.com/blog/new-in-symfony-2-8-form-improvements#allowed-to-return-null-for-query-builder for more details.

It should be kept short and straight-to-the-point, like "You can return null to achieve X".

@JonEastman
Copy link
Contributor

@wouterj I'll give the last point a shot!

JonEastman added a commit to JonEastman/symfony-docs that referenced this issue May 21, 2016
@JonEastman
Allowed to return null for query_builder
a0e3eec 
| Q             | A
| ------------- | ---
| Doc fix?      |  yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | symfony#5934
@JonEastman JonEastman mentioned this issue May 21, 2016
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label May 21, 2016
wouterj added a commit that referenced this issue May 21, 2016
@wouterj
feature #6594 Allowed to return null for query_builder (JonEastman)
3f9cf0b 
This PR was squashed before being merged into the 2.8 branch (closes #6594).

Discussion
----------

 Allowed to return null for query_builder

| Q             | A
| ------------- | ---
| Doc fix?      |  yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #5934

Commits
-------

f84a1eb  Allowed to return null for query_builder
@HeahDude
Copy link
Contributor

@wouterj Please close this one :) Thanks to everyone!

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

Yeah, this is finished now!

@xabbuh xabbuh closed this as completed May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) Hack Day hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
6 participants
@althaus @weaverryan @wouterj @xabbuh @JonEastman @HeahDude