[Form] add choice_translation_domain option to date types
#6302
Conversation
HeahDude
commented
Feb 24, 2016
HeahDude
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.8+ |
| Fixed tickets | partially #5934 |
| @@ -0,0 +1,15 @@ | |||
| choice_translation_domain | |||
There was a problem hiding this comment.
Shouldn't we reuse the already existing file from the choice type?
There was a problem hiding this comment.
I would have. Unfortunately there is a conflict between added version : 2.7 for choice types but 2.8 for date types.
Do you know a way to override only the note in a block like this ?
There was a problem hiding this comment.
Unfortunately no. But maybe we can update the description of the existing option with what you used here (imo it's more clear than what we already have).
There was a problem hiding this comment.
I don't understand, I've just copy-pasted the current description and changed the version added.
|
This one should be ready to be merged. |
|
👍 I like it. |
…ypes (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [Form] add `choice_translation_domain` option to date types | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8+ | Fixed tickets | partially #5934 Commits ------- 540cefe [Form] add `choice_translation_domain` option to date types
|
@wouterj thanks, great idea! So we can only use that file in 3.x getting rid of version added notes, right? |
|
Yes, indeed. |
