[3.4] Fixed many spelling issues found in the docs #12610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
spelling-3.4-1
branch
from
bc68743 to
23230ef
Compare
OskarStark
requested changes
Nov 8, 2019
| Retrieving the Message Catalog | ||
| ------------------------------ | ||
|
|
||
| In case you want to use the same translation catalog outside your application |
There was a problem hiding this comment.
https://english.stackexchange.com/questions/9700/outside-or-outside-of
So this is a real hard one (at least for non-natives). Seems like "outside of" is more American English, but it also has the meaning "except for" and not "outside". So I would say "outside" (without "of") is the right word here.
wouterj
force-pushed
the
spelling-3.4-1
branch
from
23230ef to
bb5fb7b
Compare
dbrumann
approved these changes
Nov 9, 2019
OskarStark
approved these changes
Nov 9, 2019
wouterj
added a commit
that referenced
this pull request
Nov 10, 2019
…erj) This PR was merged into the 3.4 branch. Discussion ---------- [3.4] Fixed many spelling issues found in the docs I was planning to do this for a long time: Run the [Sphinx spelling checker](https://pypi.org/project/sphinxcontrib.spelling/) on the Symfony documentation. This PR fixes quite a lot of spelling issues found in the files starting with `b` and `c` for the 3.4 branch. I think it's good to have these fixed, so I'm happy to merge this myself and fix any merge conflicts that might occur while doing the up-merge once. Meanwhile, I'm also preparing a "word list" of words that the spelling checker doesn't recognize. The spelling checker uses Enhant, which is [also available for PHP](https://www.php.net/manual/en/book.enchant.php). So we might be able to add this to DOCtor when all issues are fixed. cc @symfony/team-symfony-docs Commits ------- bb5fb7b Fixed many spelling issues
Merged
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2019
wouterj
added a commit
that referenced
this pull request
Jan 4, 2020
…wouterj) This PR was squashed before being merged into the 3.4 branch (closes #12837). Discussion ---------- [3.4] Fixed everything found by the spellcheck builder This completes what I started in #12610 I've also committed the custom word list and Sphinx configuration. This way, everyone is able to run it (and I accidentially removed the word list after the last time, so I don't want to loose it again). Some quick notes: * Many titles that consisted of option or function names are transformed to be a literal. This is supported by Sphinx and all references still work. On symfony.com code elements in a title are ignored and titles are displayed as normal (see https://symfony.com/doc/current/components/filesystem for an example) * I once again updated many cases of library names. I used the main website/documentation of each library to find the proper casing (e.g. NGINX, webpack, npm and HInclude.js). *To avoid merge conflicts, I will merge this PR asap. Don't worry about the merge conflicts: I'll resolve them once and then they should no longer occur* Commits ------- 715a4e7 [3.4] Fixed everything found by the spellcheck builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to do this for a long time: Run the Sphinx spelling checker on the Symfony documentation.
This PR fixes quite a lot of spelling issues found in the files starting with
bandcfor the 3.4 branch. I think it's good to have these fixed, so I'm happy to merge this myself and fix any merge conflicts that might occur while doing the up-merge once.Meanwhile, I'm also preparing a "word list" of words that the spelling checker doesn't recognize. The spelling checker uses Enhant, which is also available for PHP. So we might be able to add this to DOCtor when all issues are fixed.
cc @symfony/team-symfony-docs