-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[3.4] Fixed everything found by the spellcheck builder #12837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouter, thanks a lot for this huge effort!
37acbb8
to
3ee6d8a
Compare
@javiereguiluz this PR introduces some usage of the An alternative solution would be to remove this directives and add the remaining spellings to the wordlist and comment out the spelling configuration. But I'm not a huge fan of that (i.e. |
@wouterj about the |
For the new build tool, it would be a matter of creating the PHP class for this directive. Nothing needs to be rendered, so we just need to have the class to not have the tool fail on not knowing the directive. However, the easiest is to just add them to the global word list. I'll make that change shortly :) |
5757d6b
to
4f21744
Compare
4f21744
to
715a4e7
Compare
…wouterj) This PR was squashed before being merged into the 3.4 branch (closes #12837). Discussion ---------- [3.4] Fixed everything found by the spellcheck builder This completes what I started in #12610 I've also committed the custom word list and Sphinx configuration. This way, everyone is able to run it (and I accidentially removed the word list after the last time, so I don't want to loose it again). Some quick notes: * Many titles that consisted of option or function names are transformed to be a literal. This is supported by Sphinx and all references still work. On symfony.com code elements in a title are ignored and titles are displayed as normal (see https://symfony.com/doc/current/components/filesystem for an example) * I once again updated many cases of library names. I used the main website/documentation of each library to find the proper casing (e.g. NGINX, webpack, npm and HInclude.js). *To avoid merge conflicts, I will merge this PR asap. Don't worry about the merge conflicts: I'll resolve them once and then they should no longer occur* Commits ------- 715a4e7 [3.4] Fixed everything found by the spellcheck builder
This completes what I started in #12610
I've also committed the custom word list and Sphinx configuration. This way, everyone is able to run it (and I accidentially removed the word list after the last time, so I don't want to loose it again).
Some quick notes:
To avoid merge conflicts, I will merge this PR asap. Don't worry about the merge conflicts: I'll resolve them once and then they should no longer occur