[Components][Form] Fixed version specific examples of some form events. #3886
Conversation
ahsio
commented
May 28, 2014
ahsio
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3 |
| Fixed tickets |
- Examples that point to DataCollectorListener (added since 2.4) should be removed (or adapted when it's possible).
- This fix only applies to 2.3.
|
You're right! Since these are just examples to help you understand the purpose of what a listener might be doing on each even, what if we just added a very small note about these being a 2.4 feature? I don't think mentioning the listener in the 2.3 docs is a problem (as long as we avoid causing any confusion by pointing out that you won't see this listener unless you're looking at the 2.4 codebase). What do you think @ahsio? |
…r form extension (xabbuh) This PR was merged into the 2.4 branch. Discussion ---------- [Components][Form] add versionadded for the data collector form extension | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.4+ | Fixed tickets | As @ahsio pointed out in #3886, the data collector extension was added to the Form component in Symfony 2.4. Commits ------- beceed4 add versionadded for the data collector form extension
|
@weaverryan I do agree with you. @xabbuh 's commit should then be applied to 2.3+ Also, 2.3 links to DataCollectorListener class should point to the 2.4 version of the API. |
|
@ahsio So, after merging #3887, I actually think things are almost perfect. As I mentioned, I don't mind having the notes there, even on 2.3. But you're right that the API doc links will 404 on 2.3, which I didn't think of before. So, I think what we need to do is remove the API links on 2.3 (or all versions, I don't think they add much here) or convert them to code links (e.g. a link to that file on GitHub). What do you think? |
|
+1 for leaving the note in here @ahsio can you please update? (if you don't have time, please say so, somebody else will do it then) |
|
Replaced by #4237 |
|
@wouterj @weaverryan Sorry for not being able to adresse your questions on time! Thanks for fixing the issue! |
