Finished #3886

[wouterj]

Replaces #3886

[weaverryan]

@wouterj I want to make sure I get this merge correct: this should apply to only the 2.3 branch, correct? And so when this merges into 2.4, we'll need to revert it there.

[xabbuh]

This change is wrong. The ResizeFormListener is present in 2.3: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php

[xabbuh]

This listener exists in 2.3: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Form/Extension/Core/EventListener/TrimListener.php

[xabbuh]

@weaverryan That's right. The versionadded directives for the data collector extension already have been added in #3887.

[wouterj]

@xabbuh I decided to remove all class directives in the sidebar, to be consistent and they don
don't add any value

[xabbuh]

@wouterj I understand your concerns. Though having fully qualified class names rendered in the documentation looks pretty ugly to me. That's why I'd prefer the class here in favour of putting the FQCN in literals.

[wouterj]

@xabbuh tbh, I don't like to use the :class: API links everywhere in the documentation. In most cases, they don't add any real value. The only good thing about them, is that it allows us to "hide" the FQCN, but at the same time making it also available on hover.

I think we should make a new directive which does only that, without the link.

[xabbuh]

Of course, building such a directive should be very easy since we could reuse most of the code from the class directive. Though, what do you dislike of the the API links?

[wouterj]

@xabbuh let's take this case as an example. The class shows as an implementation example of the listener for a specific event. I don't care what the signature of the class is (in fact, everyone with a basic event system knowledge knows that it has a getSubscribedEvents method, another method and properbly a constructor), I care about the implementation. If there is anything the classname should link to, it should be the github code.

[weaverryan]

I agree. In this case, we're saying "hey, look at this core code so you can learn from it!" - so in this case, the API docs don't help (and like Wouter said, a link to the GH source code if anything would be appropriate - perhaps having an extension to make this link with the proper version would be nice). Anyways, I'm +1 for what we've done here, and in general, we'll just be thoughtful whenever we have a class :).