Update HttpFoundation note after recent changes in routing component #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[REQUEST_URI] from examples
senkal
changed the title
| Be careful when using ``$_SERVER['REQUEST_URI']``, as it may include | ||
| any query parameters on the URL, which will cause problems with route | ||
| matching. An easy way to solve this is to use the HttpFoundation component | ||
| Althought to populate parameters for :class: Symfony\\Component\\Routing\\RequestContext |
There was a problem hiding this comment.
The new phrase is not easy to read. What about rewording it as follows?
The :class:`Symfony\\Component\\Routing\\RequestContext` parameters can be populated
with the values stored in ``$_SERVER``, but it's easier to use the HttpFoundation
component as explained :ref:`below <components-routing-http-foundation>`.
|
@javiereguiluz good point. I updated the note. |
|
👍 I like this! |
|
Thank you @senkal. |
xabbuh
added a commit
that referenced
this pull request
Oct 4, 2015
…g component (senkal) This PR was squashed before being merged into the 2.3 branch (closes #5678). Discussion ---------- Update HttpFoundation note after recent changes in routing component | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Update HttpFoundation note to reflect changes in #5652. We do not longer use `$_SERVER['REQUEST_URI']` in examples so keeping the reference in note doesn't have much value. I updated it to make it more generic and reflect current examples. Commits ------- 36234f2 Update HttpFoundation note after recent changes in routing component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update HttpFoundation note to reflect changes in #5652.
We do not longer use
$_SERVER['REQUEST_URI']in examples so keeping the reference in note doesn't have much value.I updated it to make it more generic and reflect current examples.