Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HttpFoundation note after recent changes in routing component #5678

Closed
wants to merge 2 commits into from
Closed

Update HttpFoundation note after recent changes in routing component #5678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f22a4
Update HttpFoundation note to reflect recent changes- remove $_SERVER…
Sep 8, 2015
e78e017
Update HttpFoundation note
Sep 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions components/routing/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ your autoloader to load the Routing component::

.. note::

Be careful when using ``$_SERVER['REQUEST_URI']``, as it may include
any query parameters on the URL, which will cause problems with route
matching. An easy way to solve this is to use the HttpFoundation component
Althought to populate parameters for :class: Symfony\\Component\\Routing\\RequestContext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new phrase is not easy to read. What about rewording it as follows?

The :class:`Symfony\\Component\\Routing\\RequestContext` parameters can be populated
with the values stored in ``$_SERVER``, but it's easier to use the HttpFoundation
component as explained :ref:`below <components-routing-http-foundation>`.

you can use variables from ``$_SERVER``, easier way is to use HttpFoundation component
as explained :ref:`below <components-routing-http-foundation>`.

You can add as many routes as you like to a
Expand Down