If context is defined, it is used instead of the firewall #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,7 +45,7 @@ with a request. The following example demonstrates this technique:: | |||
| { | |||
| $session = $this->client->getContainer()->get('session'); | |||
|
|
|||
| $firewall = 'secured_area'; | |||
| $firewall = 'secured_area'; // put here firewalls context if defined | |||
There was a problem hiding this comment.
Maybe we can expand this a bit and put a comment like the following above this line:
// the name of the firewall to authenticate too (replace this with the value
// of the "context" option if it was used in the firewall's configuration)What do you think?
|
Hi @ruslan-fidesio! I like how you explained this variable, which is not clear at all from the code example. As the firewall context defaults to the firewall name, I think we can simply say that this is the firewall context. I've taken your commit and added a new comment, using the new wordings in #6740 This way, you still get the credits for adding this nice clarifation. Thanks for starting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be mentioned.