Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add little comment indicating meaning of $firewall variable #6740

Merged
merged 2 commits into from
Jul 9, 2016
Merged

Add little comment indicating meaning of $firewall variable #6740

merged 2 commits into from
Jul 9, 2016

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 9, 2016

Finishes #5981

@wouterj wouterj mentioned this pull request Jul 9, 2016
Closed
@javiereguiluz
Copy link
Member

javiereguiluz commented Jul 9, 2016 •
edited
Loading

👍 nice! This little detail is always confusing.

Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Jul 9, 2016

👍

@wouterj wouterj merged commit 2a702c3 into 2.7 Jul 9, 2016
wouterj added a commit that referenced this pull request Jul 9, 2016
@wouterj
minor #6740 Add little comment indicating meaning of $firewall variab…
ea9574c 
…le (ruslan-fidesio, WouterJ)

This PR was merged into the 2.7 branch.

Discussion
----------

Add little comment indicating meaning of $firewall variable

Finishes #5981

Commits
-------

2a702c3 Improve comment
2545203 If context is defined, it is used instead of the firewall
@wouterj wouterj deleted the ruslan-fidesio-patch-1 branch July 9, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @javiereguiluz @xabbuh @carsonbot @ruslan-fidesio