[Testing] Explain how to add or remove data in a collection of forms #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
alexislefebvre
force-pushed
the
test-form-with-collection-2.3
branch
from
37c7ce5 to
b645f0e
Compare
This was referenced Apr 2, 2016
alexislefebvre
changed the title
|
Can someone please give an opinion on this PR? Thanks. |
| @@ -699,6 +699,48 @@ their type:: | |||
| PHP format (it converts the keys with square brackets notation - e.g. | |||
| ``my_form[subject]`` - to PHP arrays). | |||
|
|
|||
| If you use a :doc:`Collection of Forms </cookbook/form/form_collections>`, | |||
| you can't add fields to an existing form with | |||
| ``$form['task[tags][0][name]'] = 'foo';``, this results in an error | |||
There was a problem hiding this comment.
I think "this results in [...]" should start a new sentence.
alexislefebvre
force-pushed
the
test-form-with-collection-2.3
branch
from
b645f0e to
d820e77
Compare
|
@xabbuh Thanks, I followed your advice. |
| $this->assertEquals(2, $crawler->filter('ul.tags > li')->count()); | ||
|
|
||
| Where ``task[tags][0][name]`` is the name of a field created | ||
| with Javascript. |
|
@alexislefebvre I just left some really minor last comment (we can fix that during merging). Looks good so far. 👍 |
alexislefebvre
force-pushed
the
test-form-with-collection-2.3
branch
from
d820e77 to
41276ff
Compare
weaverryan
added a commit
that referenced
this pull request
Apr 26, 2016
…tion of forms (alexislefebvre) This PR was merged into the 2.3 branch. Discussion ---------- [Testing] Explain how to add or remove data in a collection of forms | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all (based on 2.3) | Fixed tickets | - I added a part that explain how to test a [*Collection of Forms*](http://symfony.com/doc/2.3/cookbook/form/form_collections.html). Commits ------- 41276ff Tests: Explain how to add or remove data in a collection of forms
weaverryan
added a commit
that referenced
this pull request
Apr 26, 2016
|
This is great - it would be very difficult to figure out :). Thanks @alexislefebvre! |
|
Thanks you all! :) |
alexislefebvre
added a commit
to alexislefebvre/symfony-docs
that referenced
this pull request
Apr 2, 2017
xabbuh
added a commit
that referenced
this pull request
Apr 9, 2017
* 2.7: (48 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / Fix trusted hosts example regular expressions fixup comment Testing: Fix typo from #6427 Update apache_router.rst Update fortrabbit.rst Fix some YAML codes Add missing trailing comma & Fix foreach code ...
xabbuh
added a commit
that referenced
this pull request
Apr 13, 2017
* 2.8: (48 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / Fix trusted hosts example regular expressions fixup comment Testing: Fix typo from #6427 Update apache_router.rst Update fortrabbit.rst Fix some YAML codes Add missing trailing comma & Fix foreach code ...
xabbuh
added a commit
that referenced
this pull request
Apr 13, 2017
* 3.2: (60 commits) docs: choice constraints reference [#7707] minor tweak Fixed code block under "Custom Messages" [#7744] fix XSD locations Minor XML codes fixes [#7686] tweak the example code [#7663] update the PHP example code Update hostname_pattern.rst Add missing ";" Use HTTP instead of http Fixed indentation in security.rst Be consistent on service name Fix missing / typo fix Fix trusted hosts example regular expressions add reference built in listener for kernel.response event in >=3.1 fixup comment Testing: Fix typo from #6427 Update apache_router.rst Update fortrabbit.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a part that explain how to test a Collection of Forms.