Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation Constraint References] Fixed Collection model example #7686

Merged
merged 1 commit into from
Apr 8, 2017
Merged

[Validation Constraint References] Fixed Collection model example #7686

merged 1 commit into from
Apr 8, 2017

Conversation

HeahDude
Copy link
Contributor

Ref #7648.

@HeahDude HeahDude force-pushed the fix/collection-constraint branch from 81c1c8a to b1179c9 Compare March 26, 2017 15:16
@HeahDude HeahDude changed the title [Validation Contraint References] Fixed Collection model exmaple [Validation Constraint References] Fixed Collection model example Mar 26, 2017
@HeahDude HeahDude mentioned this pull request Mar 26, 2017
Closed
ghost
ghost approved these changes Mar 26, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me 👍

javiereguiluz
javiereguiluz approved these changes Mar 27, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Maybe we should use ellipsis instead of empty strings to hint that those properties should store something?

class Author
{
    protected $profileData = array(
        'personal_email' => '...',
        'short_bio' => '...',
    );

@xabbuh
Copy link
Member

xabbuh commented Apr 8, 2017

Thank you Jules.

@xabbuh xabbuh merged commit b1179c9 into symfony:2.7 Apr 8, 2017
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
minor #7686 [Validation Constraint References] Fixed Collection model…
4170916 
… example (HeahDude)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validation Constraint References] Fixed Collection model example

Ref #7648.

Commits
-------

b1179c9 [Validation Constraint References] Fixed Collection model example
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
[#7686] tweak the example code
0522de9
xabbuh added a commit that referenced this pull request Apr 9, 2017
@xabbuh
Merge branch '2.7' into 2.8
c2727e5 
* 2.7: (48 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  Fix trusted hosts example regular expressions
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  Fix some YAML codes
  Add missing trailing comma & Fix foreach code
  ...
xabbuh added a commit that referenced this pull request Apr 13, 2017
@xabbuh
Merge branch '2.8' into 3.2
fa3120e 
* 2.8: (48 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  Fix trusted hosts example regular expressions
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  Fix some YAML codes
  Add missing trailing comma & Fix foreach code
  ...
xabbuh added a commit that referenced this pull request Apr 13, 2017
@xabbuh
Merge branch '3.2'
4243346 
* 3.2: (60 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  typo fix
  Fix trusted hosts example regular expressions
  add reference built in listener for kernel.response event in >=3.1
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  ...
@HeahDude HeahDude deleted the fix/collection-constraint branch April 15, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @xabbuh @javiereguiluz @carsonbot