Update doc about IDE file link format #6944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
file-link-format
branch
2 times, most recently
from
9159515 to
25ee6f1
Compare
| You can also specify a custom URL string. If you do this, all percentage | ||
| signs (``%``) must be doubled to escape that character. For example, if | ||
| you use PHPstorm on the Mac OS platform, you will do something like: | ||
| In both cases, the expected configuration value is a URL template that should |
There was a problem hiding this comment.
that should contain -> that contains
|
👍 Status: reviewed |
nicolas-grekas
force-pushed
the
file-link-format
branch
from
25ee6f1 to
416faf1
Compare
| If you're using an IDE like TextMate or Mac Vim, then Symfony can turn all | ||
| of the file paths in an exception message into a link, which will open that | ||
| file in your IDE. | ||
| Symfony can turn file paths seen in dumps and in exception messages into links |
There was a problem hiding this comment.
you can remove the "in" before "exception messages", which will improve the read flow a bit
|
status: needs work |
nicolas-grekas
force-pushed
the
file-link-format
branch
from
416faf1 to
0cc93b2
Compare
nicolas-grekas
force-pushed
the
file-link-format
branch
from
0cc93b2 to
faeb2f7
Compare
|
comments addressed |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
symfony-splitter
pushed a commit
to symfony/debug
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
nicolas-grekas
force-pushed
the
file-link-format
branch
from
faeb2f7 to
f744396
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 16, 2016
…() instead of parse_str() (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | updated code exists only on master | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19807 | License | MIT | Doc PR | symfony/symfony-docs#6944 Because `parse_str()` turns some characters into underscores in keys (e.g. `.`). Commits ------- 9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Sep 16, 2016
…() instead of parse_str() (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | updated code exists only on master | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19807 | License | MIT | Doc PR | symfony/symfony-docs#6944 Because `parse_str()` turns some characters into underscores in keys (e.g. `.`). Commits ------- 9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Sep 16, 2016
…() instead of parse_str() (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | updated code exists only on master | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19807 | License | MIT | Doc PR | symfony/symfony-docs#6944 Because `parse_str()` turns some characters into underscores in keys (e.g. `.`). Commits ------- 9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Sep 16, 2016
…() instead of parse_str() (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | updated code exists only on master | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19807 | License | MIT | Doc PR | symfony/symfony-docs#6944 Because `parse_str()` turns some characters into underscores in keys (e.g. `.`). Commits ------- 9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
wouterj
approved these changes
Sep 18, 2016
|
👍 looks good now |
|
Thank you Nicolas. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
This PR was merged into the master branch. Discussion ---------- Update doc about IDE file link format todo: - [x] ~~tell about `kernel.file_link_format` parameter?~~ - [x] tell about prefix maps (see symfony/symfony#19807) Commits ------- f744396 Update doc about IDE file link format
This was referenced Sep 30, 2016
Merged
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
…icolas-grekas) This PR was merged into the master branch. Discussion ---------- [Framework] Update link-to-source mapping definition Follow up of #6944 and symfony/symfony#20101 Commits ------- 3a0c0d8 [Framework] Update link-to-source mapping definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
tell aboutkernel.file_link_formatparameter?