[FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links #19807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ; | ||
| $container->getDefinition('var_dumper.html_dumper') | ||
| ->replaceArgument(2, AbstractDumper::DUMP_LIGHT_ARRAY) | ||
| ; |
There was a problem hiding this comment.
This one and the previous one should probably oneliners.
There was a problem hiding this comment.
I removed this completely: not related and not a good idea anyway
nicolas-grekas
force-pushed
the
dump-link
branch
6 times, most recently
from
8972e86 to
0655c9b
Compare
nicolas-grekas
changed the title
|
PR is ready, failure unrelated (composer bug). E.g. |
nicolas-grekas
force-pushed
the
dump-link
branch
3 times, most recently
from
80afcf9 to
a258e7e
Compare
|
Can you make a PR to update the docs? |
2 tasks
|
doc PR added |
nicolas-grekas
force-pushed
the
dump-link
branch
from
a258e7e to
797b1bd
Compare
| </service> | ||
|
|
||
| <service id="data_collector.dump" class="Symfony\Component\HttpKernel\DataCollector\DumpDataCollector"> | ||
| <tag name="data_collector" id="dump" template="@Debug/Profiler/dump.html.twig" priority="240" /> | ||
| <argument type="service" id="debug.stopwatch" on-invalid="ignore" /> | ||
| <argument>null</argument><!-- %templating.helper.code.file_link_format% --> | ||
| <argument>%kernel.file_link_format%</argument> |
There was a problem hiding this comment.
I don't like the fact that this is now "global". We don't have that many global kernel.* arguments and this one does not feel like it should be one of them.
There was a problem hiding this comment.
Is it just a naming issue or the fact that it is always defined (which saves boilerplate in 4 bundles but can be removed)? Any suggestions?
There was a problem hiding this comment.
parameter renamed to debug.file_link_format
nicolas-grekas
force-pushed
the
dump-link
branch
from
797b1bd to
bf53921
Compare
nicolas-grekas
changed the title
fabpot
reviewed
Sep 14, 2016
| @@ -56,6 +56,8 @@ protected function setUp() | |||
| $this->container->setParameter('kernel.cache_dir', __DIR__); | |||
| $this->container->setParameter('kernel.debug', false); | |||
| $this->container->setParameter('kernel.root_dir', __DIR__); | |||
| $this->container->setParameter('kernel.charset', 'UTF-8'); | |||
| $this->container->setParameter('kernel.file_link_format', null); | |||
nicolas-grekas
force-pushed
the
dump-link
branch
from
bf53921 to
1c4ca8c
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 14, 2016
…mapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | #14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
nicolas-grekas
added a commit
that referenced
this pull request
Sep 16, 2016
…() instead of parse_str() (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | updated code exists only on master | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19807 | License | MIT | Doc PR | symfony/symfony-docs#6944 Because `parse_str()` turns some characters into underscores in keys (e.g. `.`). Commits ------- 9b174fb [FrameworkBundle] Parse source link maps using json_decode() instead of parse_str()
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 21, 2016
This PR was merged into the master branch. Discussion ---------- Update doc about IDE file link format todo: - [x] ~~tell about `kernel.file_link_format` parameter?~~ - [x] tell about prefix maps (see symfony/symfony#19807) Commits ------- f744396 Update doc about IDE file link format
Merged
grigoryosifov
referenced
this pull request
Feb 17, 2018
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…with remapping for IDE links (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | Fixed tickets | symfony#14340 | License | MIT | Doc PR | symfony/symfony-docs#6944 `templating.helper.code.file_link_format` is a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders. Let's make it a general parameter that can be injected easily when required. Commits ------- 1c4ca8c [FrameworkBundle] Add %debug.file_link_format% with remapping for IDE links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
templating.helper.code.file_link_formatis a parameter that requires templating to be defined, but holds a concept that is used beyond templating borders.Let's make it a general parameter that can be injected easily when required.