Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed RFC links from drafts to proposed standarts #7034

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions http_cache.rst
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,8 @@ These four headers are used to help cache your responses via *two* different mod

All of the HTTP headers you'll read about are *not* invented by Symfony! They're
part of an HTTP specification that's used by sites all over the web. To dig deeper
into HTTP Caching, check out the original `RFC 2616`_ document, or these two
other pieces: `P4 - Conditional Requests`_ and `P6 -
Caching: Browser and intermediary caches`_.
into HTTP Caching, check out the original documents `RFC 7234 - Caching`_ and
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps leave original out in this sentence as I think that referred to RFC 2616.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Fixed as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we wanna keep the reference to RFC 2616?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh, why do you think it makes sense?
Mark Nottingham recommends to forget about 2616 and use newer specs:
'These documents are now RFCs that collectively replace RFC2616, and should be referenced and used in its place'.

`RFC 7232 - Conditional Requests`_.

As a web developer, you are strongly urged to read the specification. Its
clarity and power - even more than fifteen years after its creation - is
Expand Down Expand Up @@ -362,10 +361,9 @@ Learn more
.. _`Things Caches Do`: http://2ndscale.com/writings/things-caches-do
.. _`Cache Tutorial`: http://www.mnot.net/cache_docs/
.. _`Varnish`: https://www.varnish-cache.org/
.. _`Squid in reverse proxy mode`: http://wiki.squid-cache.org/SquidFaq/ReverseProxy
.. _`RFC 2616`: http://tools.ietf.org/html/rfc2616
.. _`Squid in reverse proxy mode`: http://wiki.squid-cache.org/SquidFaq/ReverseProxy7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this accidental change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very much, @snoek09
Fixed

.. _`HTTP Bis`: http://tools.ietf.org/wg/httpbis/
.. _`P4 - Conditional Requests`: http://tools.ietf.org/html/draft-ietf-httpbis-p4-conditional
.. _`P6 - Caching: Browser and intermediary caches`: http://tools.ietf.org/html/draft-ietf-httpbis-p6-cache
.. _`RFC 7234 - Caching`: https://tools.ietf.org/html/rfc7234
.. _`RFC 7232 - Conditional Requests`: https://tools.ietf.org/html/rfc7232
.. _`FOSHttpCacheBundle`: http://foshttpcachebundle.readthedocs.org/
.. _`HTTP specification`: http://www.w3.org/Protocols/rfc2616/rfc2616.html