Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed RFC links from drafts to proposed standarts #7034

Closed
wants to merge 3 commits into from

Conversation

a-ast
Copy link
Contributor

@a-ast a-ast commented Oct 4, 2016

First 'HTTP Cache' documentation page had been created in May 2013 when RFC 7232 and 7234 were still drafts.
I think it makes sense now to change links from drafts to proposed standards and remove the reference to old good RFC 2616 which is already obsolete.

First 'HTTP Cache' documentation page had been created in May 2013 when RFC 7232 and 7234 were still drafts.
I think it makes sense now to change links from drafts to proposed standards and remove the reference to old good RFC 2616 which is already obsolete.
@@ -362,10 +361,9 @@ Learn more
.. _`Things Caches Do`: http://2ndscale.com/writings/things-caches-do
.. _`Cache Tutorial`: http://www.mnot.net/cache_docs/
.. _`Varnish`: https://www.varnish-cache.org/
.. _`Squid in reverse proxy mode`: http://wiki.squid-cache.org/SquidFaq/ReverseProxy
.. _`RFC 2616`: http://tools.ietf.org/html/rfc2616
.. _`Squid in reverse proxy mode`: http://wiki.squid-cache.org/SquidFaq/ReverseProxy7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this accidental change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very much, @snoek09
Fixed

@a-ast
Copy link
Contributor Author

a-ast commented Oct 6, 2016

@javiereguiluz, do you have an idea why checks failed after my second commit?

into HTTP Caching, check out the original `RFC 2616`_ document, or these two
other pieces: `P4 - Conditional Requests`_ and `P6 -
Caching: Browser and intermediary caches`_.
into HTTP Caching, check out the original documents `RFC 7234 - Caching`_ and
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps leave original out in this sentence as I think that referred to RFC 2616.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Fixed as well.

@javiereguiluz
Copy link
Member

@a-ast I don't know why it's failing. Everything looks OK to me and the rendered page is working as expected:

new_links

👍 Thanks for this improvement.

@wouterj
Copy link
Member

wouterj commented Oct 6, 2016

The error is not related to this PR. Seems like a regression on platform.sh's side.

status: reviewed

@@ -192,9 +192,8 @@ These four headers are used to help cache your responses via *two* different mod

All of the HTTP headers you'll read about are *not* invented by Symfony! They're
part of an HTTP specification that's used by sites all over the web. To dig deeper
into HTTP Caching, check out the original `RFC 2616`_ document, or these two
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we wanna keep the reference to RFC 2616?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh, why do you think it makes sense?
Mark Nottingham recommends to forget about 2616 and use newer specs:
'These documents are now RFCs that collectively replace RFC2616, and should be referenced and used in its place'.

@xabbuh
Copy link
Member

xabbuh commented Oct 14, 2016

Thank you @a-ast.

xabbuh added a commit that referenced this pull request Oct 14, 2016
This PR was squashed before being merged into the 2.7 branch (closes #7034).

Discussion
----------

Changed RFC links from drafts to proposed standarts

First 'HTTP Cache' documentation page had been created in May 2013 when RFC 7232 and 7234 were still drafts.
I think it makes sense now to change links from drafts to proposed standards and remove the reference to old good RFC 2616 which is already obsolete.

Commits
-------

098d29c Changed RFC links from drafts to proposed standarts
@xabbuh xabbuh closed this Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants