-
-
Notifications
You must be signed in to change notification settings - Fork 354
[DX][Components] Twig components case sensitivity / HTML syntax #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey Simon, thanks for opening the discussion! 🙏🏻 Symfony UX ComponentsPersonally I prefer the form For me:
App/User-Land/Bundle Components
Thanks! |
I answer like @Kocal for the 6 points. And for my part, I prefer PascalCase to lower-case. |
Updated A2, let's keep using kebab-case |
After some though, i see no problem we use both, as user can use both. So as long we do not change again for icon ( 😅 ) if you want to change for Map, or add some Kebad case in the documentation, I agree and am ok to give a hand if you want After all..... we are not that many to contribute here, I think we can have double vote 😅 |
Primer use PascalCase too, but i'm sure you now understand why i'd like to avoid it (now) |
So, is the consensus that we'll use kebab for "official" components, but promote PascalCase for user-land ones? And if this is the consensus, should #2481 be changed to kebab-case? |
As you want guys, as long we do not need to refactor doc / website twice a year haha |
TL;DR; ⏲️
Context 🔠
While working on UX Map, @Kocal raised a question during the discussion:
During the development and early stages of UX Icons, @kbond and I decided to switch from
<twig:Ux:Icon />
to<twig:ux:icon />
both in the code and in the documentation.This change felt more natural for typing and reading in the documentation. Additionally, since "
<twig
" is lowercase, "<twig:ux
" seemed more consistent to me. As a result, we made it case-insensitive.However, this is the only place where it works this way, as user-land component names are still case-sensitive.
Suggestions 🗳️
I’d like to gather feedback from the team and community on the following points:
Symfony UX Components
App/User-Land/Bundle Components
Acme:Foo
andacMe:foo
from being registered simultaneously)..
I’m inclined to answer "yes" to all these points.
Let’s discuss them and hear from you if there are any concerns. :)
The text was updated successfully, but these errors were encountered: