Skip to content

[Icons] Use lowercase <twig:ux:icon /> in documentation #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

smnandre
Copy link
Member

As previously discussed with @kbond, we should use only one format in documentation / website / etc.

(both will work, it really is "just" a communication thing)

This PR update the documentation and the README (website is already OK)

@carsonbot carsonbot added Icons Status: Needs Review Needs to be reviewed labels Apr 28, 2024
@smnandre smnandre added docs Improvements or additions to documentation and removed Status: Needs Review Needs to be reviewed labels Apr 28, 2024
@smnandre smnandre requested a review from kbond April 28, 2024 16:20
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 28, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 30, 2024
@kbond kbond force-pushed the doc/ux-icon-lowercase branch from 8e4e8e0 to 1cd8e92 Compare April 30, 2024 14:17
@kbond
Copy link
Member

kbond commented Apr 30, 2024

Thanks Simon.

@kbond kbond merged commit f8b2344 into symfony:2.x Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Icons Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants