Allow to use the [N] placeholder in copyFiles() #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
file-loader-regexp
branch
from
effe965 to
76b0bec
Compare
Collaborator
Author
|
Failing tests are unrelated (see #650) |
Lyrkan
force-pushed
the
file-loader-regexp
branch
from
76b0bec to
b8ac398
Compare
Member
|
Sorry for the delay. This is a pretty wild, in-depth solution. But it's well-covered with a test and I appreciate you checked it in Webpack 5 alpha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #647 by passing the
regExpoption to thefile-loaderused byEncore.copyFiles().It's a bit hacky since it changes the loader's options from the loader itself, but we should probably be fine for a while (I also tested it with
webpack@5.0.0-alpha.29and the latest version offile-loader@4.2.0).