Fix hashes in the "Copy with versioning enabled" test #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Oct 9, 2019
Member
|
Thanks for catching that for me @Lyrkan :) |
weaverryan
added a commit
that referenced
this pull request
Oct 9, 2019
…kan) This PR was merged into the master branch. Discussion ---------- Fix hashes in the "Copy with versioning enabled" test Fix a broken test on develop following the merge of #648. Not sure why the main.js and runtime.js hashes changed, but their content stayed exactly the same. Commits ------- 84561d9 Fix hashes in the "Copy with versioning enabled" test
Member
That's because webpack 4 is not hashing the output file. The hash is based on input files and some parts of the webpack config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a broken test on develop following the merge of #648.
Not sure why the main.js and runtime.js hashes changed, but their content stayed exactly the same.