Add format_matrix_subscript_accessor and update_template_data to CodegenConfig #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review adds two small methods to
CodegenConfig
, with the intention of making it easier to support additional languages:format_matrix_subscript_accessor
, which formats the accessor for 2D matrices. This is required in some languages where thefoo(i, j)
syntax is unavailable. In keeping w/ Hayk's comment onformat_data_accessor
, I put a TODO suggesting this could potentially be moved into the code-printer itself.update_template_data
, which allowsCodegenConfig
subclasses to pass additional fields or functions to the templating engine.