Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export archives in eml format #1581

Closed
SansPseudoFix opened this issue Jan 17, 2023 · 1 comment · Fixed by #1582
Closed

Export archives in eml format #1581

SansPseudoFix opened this issue Jan 17, 2023 · 1 comment · Fixed by #1582

Comments

@SansPseudoFix
Copy link

SansPseudoFix commented Jan 17, 2023

Expected Behavior

To make sympa archives easy to import into Thunderbird, it would be appreciated to have .eml extension. Thus, it would be as simple as copying and pasting the folder into the local folder or using an import add-on.

Current Behavior

No extension means we have to add .eml to every files. Not an easy thing for non-technical people.

Possible Solution

Here a snippet made by @ldidry for Framalistes:

@@ -15708,12 +15712,12 @@ sub do_arc_download {
             my ($rv, $az);
             if ($Archive::Zip::SimpleZip::VERSION) {
                 $rv = $zip->addString($message->as_string,
-                    Name => sprintf('%s/%s', $arc_dirname, $handle->basename)
+                    Name => sprintf('%s/%s.eml', $arc_dirname, $handle->basename)
                 );
                 $az = $Archive::Zip::SimpleZip::SimpleZipError;
             } else {
                 $rv = $zip->addString($message->as_string,
-                    sprintf('%s/%s', $arc_dirname, $handle->basename));
+                    sprintf('%s/%s.eml', $arc_dirname, $handle->basename));
                 $az = 'unknown error';
             }
             unless ($rv) {

Context

Framalistes deletes archives older than 12 months now, so it would be handy for users to have easy to use archive files to import (into Thunderbird, at least).

@ikedas
Copy link
Member

ikedas commented Jan 18, 2023

Hi @SansPseudoFix ,

I feel your suggestion makes sense. How about submitting your suggestion as a pull request?

ldidry added a commit to ldidry/sympa that referenced this issue Jan 19, 2023
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Jan 19, 2023
@ikedas ikedas removed the ready A PR is waiting to be merged. Close to be solved label Jun 2, 2023
ldidry added a commit to ldidry/sympa that referenced this issue Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants