Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .eml extension to archives files #1582

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Jan 19, 2023

Fix #1581

@ldidry ldidry requested review from racke and ikedas April 18, 2023 05:48
@ikedas
Copy link
Member

ikedas commented Apr 19, 2023

I think it is desirable to convert line breaks from <LF> to <CR><LF> in the .eml files to be included in the ZIP file.

It appears that newlines in .eml files would be better to be <CR><LF>. At least Firefox uses <CR><LF> in the .eml files it exports. Also, from this discussion, this seems to be the intended behavior. There may be some other applications that cannot open .eml files without <CR><LF> (Firefox itself, in recent versions, can open message files even if they use <LF>).

In contrast, many MTAs/MDAs on Unixen use native newlines when storing messages or passing messages to external programs: At least mbox (most of variants) and Maildir formats convert newlines to <LF>. That's why <LF> is also used for messages stored by Sympa.

@ikedas
Copy link
Member

ikedas commented Jun 23, 2023

I agree to tag this PR "ready".

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Jun 27, 2023
@racke racke added this to the 6.2.74 milestone Dec 7, 2023
@racke racke merged commit 0c727c2 into sympa-community:main Dec 7, 2023
@sympa-community sympa-community locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export archives in eml format
3 participants