Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skrink macos brew & flags #4

Merged
merged 8 commits into from
Aug 12, 2022
Merged

feat: skrink macos brew & flags #4

merged 8 commits into from
Aug 12, 2022

Conversation

fumiama
Copy link

@fumiama fumiama commented Aug 12, 2022

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 12, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.92%.

Quality metrics Before After Change
Complexity 5.37 ⭐ 4.49 ⭐ -0.88 👍
Method Length 82.77 🙂 75.93 🙂 -6.84 👍
Working memory 6.98 🙂 6.91 🙂 -0.07 👍
Quality 66.78% 🙂 68.70% 🙂 1.92% 👍
Other metrics Before After Change
Lines 341 346 5
Changed files Quality Before Quality After Quality Change
setup.py 66.78% 🙂 68.70% 🙂 1.92% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@fumiama fumiama requested a review from synodriver August 12, 2022 13:08
@synodriver synodriver force-pushed the speedup branch 3 times, most recently from a18cc61 to a9873b8 Compare August 12, 2022 14:02
@synodriver synodriver merged commit b9b0e9d into synodriver:speedup Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants