-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skrink macos brew & flags (Sourcery refactored) #5
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 1.90%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
65f0d8c
to
2fc1dac
Compare
2fc1dac
to
6af4b5f
Compare
6af4b5f
to
41ebdf8
Compare
41ebdf8
to
cd3361c
Compare
cd3361c
to
e472a76
Compare
e472a76
to
b7393e2
Compare
# extract dic | ||
filename = "dic.tar.gz" | ||
print('Downloading: "{}"'.format(_DICT_URL)) | ||
print(f'Downloading: "{_DICT_URL}"') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 182-287
refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting
) - Use f-string instead of string concatenation [×3] (
use-fstring-for-concatenation
)
def create_version_file(): | ||
global version, cwd | ||
print("-- Building version " + version) | ||
print(f"-- Building version {version}") | ||
version_path = os.path.join(cwd, "pyopenjtalk", "version.py") | ||
with open(version_path, "w") as f: | ||
f.write("__version__ = '{}'\n".format(version)) | ||
f.write(f"__version__ = '{version}'\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function build_py.create_version_file
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
) - Replace call to format with f-string (
use-fstring-for-formatting
)
install_requires=[ | ||
"numpy >= 1.20.0", | ||
"cython >= " + min_cython_ver, | ||
f"cython >= {min_cython_ver}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 337-337
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
a18cc61
to
a9873b8
Compare
Pull Request #4 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!