Change authorized domain table name to snake case #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timmess
commented
Feb 21, 2024
timmess
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Fixed issue | #... |
| License | MIT |
timmess
changed the title
Jibbarth
reviewed
Feb 21, 2024
| @@ -8,6 +8,7 @@ | |||
| use Sylius\Component\Resource\Model\ResourceInterface; | |||
| use Synolia\SyliusAdminOauthPlugin\Repository\AuthorizedDomainRepository; | |||
|
|
|||
| #[ORM\Table(name: 'authorized_domain')] | |||
There was a problem hiding this comment.
We should prefix it with vendor name (synolia_)
oallain
reviewed
Feb 23, 2024
| @@ -8,6 +8,7 @@ | |||
| use Sylius\Component\Resource\Model\ResourceInterface; | |||
| use Synolia\SyliusAdminOauthPlugin\Repository\AuthorizedDomainRepository; | |||
|
|
|||
| #[ORM\Table(name: 'synolia_authorized_domain')] | |||
There was a problem hiding this comment.
Isn't it a good idea to do this for all attributes? For example, $isEnabled will be isEnabled in the database, won't it?
timmess
force-pushed
the
hotfix/authorized-domain-table-name
branch
from
b9b0cef to
1b29f6d
Compare
oallain
approved these changes
Feb 29, 2024
|
You need to upgrade MariaDB set image: 'mariadb:10.11'
Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.