Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change authorized domain table name to snake case #19

Merged
merged 4 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions migrations/Version20240221095851.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

declare(strict_types=1);

namespace DoctrineMigrations;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;

/**
* Auto-generated Migration: Please modify to your needs!
*/
final class Version20240221095851 extends AbstractMigration
{
public function getDescription(): string
{
return 'Modify AuthorizedDomain table name to snake case';
}

public function up(Schema $schema): void
{
// this up() migration is auto-generated, please modify it to your needs
$this->addSql('ALTER TABLE AuthorizedDomain RENAME TO synolia_authorized_domain ');
}

public function down(Schema $schema): void
{
// this down() migration is auto-generated, please modify it to your needs
$this->addSql('ALTER TABLE synolia_authorized_domain RENAME TO AuthorizedDomain ');
}
}
1 change: 1 addition & 0 deletions src/Entity/Domain/AuthorizedDomain.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Sylius\Component\Resource\Model\ResourceInterface;
use Synolia\SyliusAdminOauthPlugin\Repository\AuthorizedDomainRepository;

#[ORM\Table(name: 'synolia_authorized_domain')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a good idea to do this for all attributes? For example, $isEnabled will be isEnabled in the database, won't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally

#[ORM\Entity(repositoryClass: AuthorizedDomainRepository::class)]
class AuthorizedDomain implements ResourceInterface
{
Expand Down
Loading